This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
configure: add --without-mdb flag #25707
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a configuration flag that prevents mdb_v8.so from being built. The default behavior is still the same and mdb_v8.so is built by default on Solaris based platforms such as SmartOS. Using --without-mdb fixes build issues on Solaris based platforms where libproc.h is not available or not compatible with the one shipped by SmartOS. Fixes nodejs#6439.
misterdjules
force-pushed
the
fix-issue-6439
branch
from
232fce3
to
c0872b3
Compare
|
This was already reviewed at #9349, landing in v0.12 now. |
This was referenced Jul 17, 2015
misterdjules
pushed a commit
that referenced
this pull request
Jul 17, 2015
Add a configuration flag that prevents mdb_v8.so from being built. The default behavior is still the same and mdb_v8.so is built by default on Solaris based platforms such as SmartOS. Using --without-mdb fixes build issues on Solaris based platforms where libproc.h is not available or not compatible with the one shipped by SmartOS. Fixes #6439. Reviewed-By: Julien Gilli <[email protected]> PR-URL: #25707
misterdjules
pushed a commit
that referenced
this pull request
Jul 17, 2015
Reviewed-By: Julien Gilli <[email protected]> PR-URL: #25707
|
Landed in 8b81f98, thank you @cgalibern 👍 |
jBarz
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Nov 4, 2016
Add a configuration flag that prevents mdb_v8.so from being built. The default behavior is still the same and mdb_v8.so is built by default on Solaris based platforms such as SmartOS. Using --without-mdb fixes build issues on Solaris based platforms where libproc.h is not available or not compatible with the one shipped by SmartOS. Fixes nodejs#6439. Reviewed-By: Julien Gilli <[email protected]> PR-URL: nodejs#25707
jBarz
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Nov 4, 2016
Reviewed-By: Julien Gilli <[email protected]> PR-URL: nodejs#25707
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes build issues on Solaris based platforms where libproc.h is not
available or not compatible with the one shipped by SmartOS.
Fixes #6439.
This is just a PR that fixes the commit message from #9349. It's otherwise strictly identical.